AsyncBuffer update #130
Open
AsyncBuffer update #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
reviewed
Oct 27, 2024
ldp/alg/rollout.py
Outdated
| @@ -194,12 +194,16 @@ async def _sample_trajectories_from_envs( | |||
| self.traj_buffer.clear() | |||
|
|
|||
| traj_ids = [uuid.uuid4().hex for _ in range(len(environments))] | |||
| await asyncio.gather( | |||
| from tqdm.asyncio import tqdm_asyncio | |||
There was a problem hiding this comment.
Can we import this at the module level?
Comment on lines
+202
to
+206
| try: | ||
| # Wait for either the batch to fill up or the timeout to expire | ||
| await asyncio.wait_for(self._batch_ready_event.wait(), timeout=self.timeout) | ||
| except asyncio.TimeoutError: | ||
| pass |
There was a problem hiding this comment.
async with asyncio.timeout(self.timeout):
# Wait for either the batch to fill up or the timeout to expire
self._batch_ready_event.wait()
Alternate way of doing this using built-in asyncio.timeout
I am not sure if you need to await the wait()
| await self._processed_events[request_id].wait() | ||
|
|
||
| async with self._lock: | ||
| print(f"Finished Request ID: {request_id}, Counter: {self._events_count[request_id]}") |
There was a problem hiding this comment.
Let's use logging not print
| self._processed_events[request_id] = asyncio.Event() | ||
| self._events_count[request_id] = self._counter | ||
| self._counter += 1 | ||
| print(f"Started Request ID: {request_id}, Counter: {self._events_count[request_id]}") |
There was a problem hiding this comment.
Let's use logging over print
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.